Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correction the home page #240

Closed
wants to merge 1 commit into from
Closed

correction the home page #240

wants to merge 1 commit into from

Conversation

BajalanIman
Copy link
Collaborator

There was a bug on the home page with the replication of data. I've resolved this bug in this ticket.
image

@BajalanIman BajalanIman added the bug Something isn't working label Oct 24, 2024
@BajalanIman BajalanIman linked an issue Oct 24, 2024 that may be closed by this pull request
Correction of the home page #239
Open
@006080
Copy link
Collaborator

006080 commented Oct 24, 2024

Sorry, Iman, but it seems you are not taking into consideration the work done by other people. Can you see a Share Icon in the right corner? When clicked, it should open a Share Popup modal. The Carousel icon also has functionality. I am really tired of making corrections to it every time. Please pay attention to the contributions of other collaborators. Thanks!

@BajalanIman
Copy link
Collaborator Author

@006080 Maybe I didn't still get the point correctly, but what I can see in the main branch right now is this:

image

Also, by clicking the image, we should jump to the product page, but it's not working.

@006080
Copy link
Collaborator

006080 commented Oct 24, 2024

#241
Can you see this ticket that is waiting to be approved?

@006080
Copy link
Collaborator

006080 commented Oct 24, 2024

I was hurrying fixing it this time, because we have a demo tonight. It is bringing us to the ProductPage clicking on Title, Hosl, Price.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grabinskij grabinskij Awaiting requested review from grabinskij

@Konzisam Konzisam Awaiting requested review from Konzisam

@alinaincodeland alinaincodeland Awaiting requested review from alinaincodeland

@dvnishshanka dvnishshanka Awaiting requested review from dvnishshanka

@006080 006080 Awaiting requested review from 006080

@GabrielMelhem GabrielMelhem Awaiting requested review from GabrielMelhem

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correction of the home page
2 participants
@BajalanIman @006080