You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When installing the "modifiedcommunitymodules/recover-cart-sales" module through MMLC and prompted to copy template files to the shop, an issue arises if the original template in the shop no longer exists. Post-installation, the module displays "changes" that cannot be automatically discarded.
Steps to Reproduce:
Rename the original templates in the shop.
Install the "modifiedcommunitymodules/recover-cart-sales" module through MMLC.
Expected Behavior:
The module installation should handle cases where the original template in the shop is renamed, ensuring smooth integration without displaying unactionable "changes."
Actual Behavior:
After installation, the module presents "changes" that cannot be automatically discarded due to the absence of the original template in the shop.
Additional Information:
MMLC Version: 1.19.1
Shop Version: 2.0.7.2
The text was updated successfully, but these errors were encountered:
The error still exists in MMLC version 1.23.0 with the new ModuleManager / ModuleInstaller and the new Module Info Buttons.
I think we need to completely overhaul how template files are installed and handled.
Here are some ideas that are not complete:
A main template should be able to be set in moduleinfo.json.
The files from the main template will be transferred to all previous templates during installation if they are not already present.
The files from other specific templates are only transferred to the respective template if they do not already exist.
If there are the same file paths in the main template and a specific template, the file from the specific template will be used and not the one from the main template.
Changes to template files are also monitored.
A distinction is made between code and template changes.
If you also want to deliver templates with the MMLC, you must be able to specify that files can also be transferred to templates that do not exist. Maybe a isTemplate Flag in moduleinfo.json
Description:
When installing the "modifiedcommunitymodules/recover-cart-sales" module through MMLC and prompted to copy template files to the shop, an issue arises if the original template in the shop no longer exists. Post-installation, the module displays "changes" that cannot be automatically discarded.
Steps to Reproduce:
Expected Behavior:
The module installation should handle cases where the original template in the shop is renamed, ensuring smooth integration without displaying unactionable "changes."
Actual Behavior:
After installation, the module presents "changes" that cannot be automatically discarded due to the absence of the original template in the shop.
Additional Information:
The text was updated successfully, but these errors were encountered: