Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"recover-cart-sales" Module in MMLC Displays Unresolvable Changes #143

Open
RobinTheHood opened this issue Nov 9, 2023 · 1 comment
Open
Labels
bug Something isn't working
Milestone

Comments

@RobinTheHood
Copy link
Owner

Description:

When installing the "modifiedcommunitymodules/recover-cart-sales" module through MMLC and prompted to copy template files to the shop, an issue arises if the original template in the shop no longer exists. Post-installation, the module displays "changes" that cannot be automatically discarded.

Steps to Reproduce:

  1. Rename the original templates in the shop.
  2. Install the "modifiedcommunitymodules/recover-cart-sales" module through MMLC.

Expected Behavior:
The module installation should handle cases where the original template in the shop is renamed, ensuring smooth integration without displaying unactionable "changes."

Actual Behavior:
After installation, the module presents "changes" that cannot be automatically discarded due to the absence of the original template in the shop.

Additional Information:

  • MMLC Version: 1.19.1
  • Shop Version: 2.0.7.2
@RobinTheHood RobinTheHood added the bug Something isn't working label Nov 9, 2023
@RobinTheHood RobinTheHood added this to the v1.22.0 milestone Nov 9, 2023
@RobinTheHood RobinTheHood modified the milestones: v1.22.0, Backlog Nov 26, 2023
@RobinTheHood RobinTheHood modified the milestones: Backlog, v1.23.0 Dec 5, 2023
@RobinTheHood
Copy link
Owner Author

The error still exists in MMLC version 1.23.0 with the new ModuleManager / ModuleInstaller and the new Module Info Buttons.

I think we need to completely overhaul how template files are installed and handled.

Here are some ideas that are not complete:

  • A main template should be able to be set in moduleinfo.json.
  • The files from the main template will be transferred to all previous templates during installation if they are not already present.
  • The files from other specific templates are only transferred to the respective template if they do not already exist.
  • If there are the same file paths in the main template and a specific template, the file from the specific template will be used and not the one from the main template.
  • Changes to template files are also monitored.
  • A distinction is made between code and template changes.
  • If you also want to deliver templates with the MMLC, you must be able to specify that files can also be transferred to templates that do not exist. Maybe a isTemplate Flag in moduleinfo.json

@RobinTheHood RobinTheHood modified the milestones: v1.23.0, Backlog Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant