Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrates to WXT #105

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Migrates to WXT #105

wants to merge 15 commits into from

Conversation

Royal-lobster
Copy link
Owner

Closes #103

@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 406f433

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Adebesin-Cell
Copy link
Collaborator

Help wanted?

@Royal-lobster
Copy link
Owner Author

Help wanted?

Oh yes ! help always welcome, for this you need this: then pnpm dev would open vivaldi with dev extension installed automatically

// web-ext.config.ts

import { defineRunnerConfig } from 'wxt'

export default defineRunnerConfig({
  binaries: {
    chrome: '/Applications/Vivaldi.app/Contents/MacOS/Vivaldi',
  },
})

@Adebesin-Cell
Copy link
Collaborator

Adebesin-Cell commented Jan 17, 2025 •
edited
Loading

Help wanted?

Oh yes ! help always welcome, for this you need this: then pnpm dev would open vivaldi with dev extension installed automatically

// web-ext.config.ts

import { defineRunnerConfig } from 'wxt'

export default defineRunnerConfig({
  binaries: {
    chrome: '/Applications/Vivaldi.app/Contents/MacOS/Vivaldi',
  },
})

Got it, thanks! 👏

@Adebesin-Cell
Copy link
Collaborator

Screenshot 2025-01-19 at 7 04 54 PM

Perhaps I'm doing sth wrong, trying to run the extensions, I altered pages to point to entrypoints since it felt like a path issue, but get same error.
How did you resolve the error?

@Royal-lobster
Copy link
Owner Author

Perhaps I'm doing sth wrong, trying to run the extensions, I altered pages to point to entrypoints since it felt like a path issue, but get same error. How did you resolve the error?

Hmm seeing this for first time, but yeah i think first we need to do the folder structure refactoring to match wxt framework. i think it should work once we set it up

@Adebesin-Cell
Copy link
Collaborator

Perhaps I'm doing sth wrong, trying to run the extensions, I altered pages to point to entrypoints since it felt like a path issue, but get same error. How did you resolve the error?

Hmm seeing this for first time, but yeah i think first we need to do the folder structure refactoring to match wxt framework. i think it should work once we set it up

Screenshot 2025-01-25 at 9 43 39 PM

Yep, seems it's file path issue, different error this time 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
💬 Project Syncia
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite to use WXT
2 participants
@Royal-lobster @Adebesin-Cell