Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnumValue deserialization fails #273

Closed
sourabhsparkala opened this issue Jul 14, 2020 · 0 comments · Fixed by #286
Closed

EnumValue deserialization fails #273

sourabhsparkala opened this issue Jul 14, 2020 · 0 comments · Fixed by #286
Assignees
@artem-smotrakov
Milestone
0.12.0

Comments

@sourabhsparkala
Copy link
Member

In reference to #263 (comment)

As per the discussion jackson-databind seems to have resolved this issue FasterXML/jackson-databind#2605

But still the unit test https://github.com/SAP/fosstars-rating-core/blob/master/src/test/java/com/sap/sgs/phosphor/fosstars/model/value/EnumValueTest.java#L88 fails.

This has to be resolved. The issue seems to be fixed with jackson-databind:2.11.1.
@sourabhsparkala sourabhsparkala mentioned this issue Jul 14, 2020
Merged
@artem-smotrakov artem-smotrakov added this to the 0.12.0 milestone Jul 16, 2020
@artem-smotrakov artem-smotrakov self-assigned this Jul 20, 2020
@artem-smotrakov artem-smotrakov changed the title EnumValue fails with serialization issue EnumValue deserialization fails Jul 22, 2020
artem-smotrakov added a commit to artem-smotrakov/fosstars-rating-core that referenced this issue Jul 22, 2020
@artem-smotrakov
Fix deserialization of EnumValue
f48a4f0 
- Added EnumFeature
- Updated Jackson version
- Added JsonTypeInfo annotation to EnumValue.value
- Updated tests

This fixes SAP#273
artem-smotrakov added a commit to artem-smotrakov/fosstars-rating-core that referenced this issue Jul 22, 2020
@artem-smotrakov
Fix deserialization of EnumValue
2a7fb2d 
- Added EnumFeature
- Updated Jackson version
- Added JsonTypeInfo annotation to EnumValue.value
- Updated tests

This fixes SAP#273
@artem-smotrakov artem-smotrakov mentioned this issue Jul 22, 2020
Merged
artem-smotrakov added a commit that referenced this issue Jul 23, 2020
@artem-smotrakov
Fix deserialization of EnumValue
f13077a 
- Added EnumFeature
- Updated Jackson version
- Added JsonTypeInfo annotation to EnumValue.value
- Updated tests

This fixes #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artem-smotrakov artem-smotrakov

Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Fix deserialization of EnumValue artem-smotrakov/fosstars-rating-core
2 participants
@sourabhsparkala @artem-smotrakov