Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ SSW.Rules CSS - List bullet points are generated in a inadequate way #1616

Open
1 task
tiagov8 opened this issue Nov 5, 2024 · 0 comments
Open
1 task
Labels
Type: Refactor A code quality improvement e.g. Tech debt

Comments

@tiagov8
Copy link
Member

tiagov8 commented Nov 5, 2024

Cc: @hveraus @bettybondoc

Hi team

Pain

Bullet points on lists are squared and red, which is cool, but it uses a less-than-ideal CSS:

#rules ul li, .rule-category-top ol li, .rule-category-top ul li, .rule-content ol li, .rule-content ul li {
    line-height: 1.25rem;
    padding: 0 0 .5rem;
}
.rule-category-top ol li, .rule-category-top ul li, .rule-content ol li, .rule-content ul li {
    margin-bottom: .25rem;
}
#rules ul>li:before, .rule-category-top ul>li:before, .rule-content ul>li:before {
    --tw-text-opacity: 1;
    color: rgb(204 65 65 / var(--tw-text-opacity));
    content: "\25A0";
    display: inline-block;
    margin-left: -1rem;
    width: 1rem;
}

I noticed in some browsers the bullet points are missaligned and/or too big.

What code could be improved?

We can achieve a similar and better results by using:

li {
  list-style-type: square;
  padding: 0 0 .5rem;
}
li::marker {
  color: #cc4141;
}

Tasks

  • 1. Fix the CSS

Screenshots

Thanks

@tiagov8 tiagov8 added the Type: Refactor A code quality improvement e.g. Tech debt label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor A code quality improvement e.g. Tech debt
Projects
None yet
Development

No branches or pull requests

1 participant