Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for intrumenting and computing the coverage of test classes #96

Open
andre15silva opened this issue Jun 29, 2021 · 3 comments
Open

Comments

@andre15silva
Copy link
Contributor

Right now, only source classes are instrumented. We should have an option for enabling test instrumentation too.

@martinezmatias
Copy link
Contributor

Hi @andre15silva

Right now, only source classes are instrumented. We should have an option for enabling test instrumentation too.

I think we have it (as far I remember I implemented):

The boolean field that indicates whether we would cover or not code from tests is here:
https://github.com/SpoonLabs/flacoco/blob/master/src/main/java/fr/spoonlabs/flacoco/core/config/FlacocoConfig.java#L32

@andre15silva
Copy link
Contributor Author

Hi @martinezmatias ,

yes, but you instrumented the test classes in CoverageRunner, which now isn't an option since we use test-runner through the EntryPoint.

I'm just finishing a PR to test-runner which enables an options for covering the tests.

@martinezmatias
Copy link
Contributor

Thanks @andre15silva

yes, but you instrumented the test classes in CoverageRunner, which now isn't an option since we use test-runner through the EntryPoint.

Perfect. I forgot the new way we interact with 'test-runner'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants