ra/* - hdbMap usage should be revised

[PeterPitterling]

SAPHana - is not used at all and can be removed

SAPHanaSR/ra/SAPHana

Line 1001 in fabfd37

hdbMap="hdbnsutil -sr_state"

SAPHanaTopology - only used for >= 1.00.111 - sr_state never ever called

SAPHanaSR/ra/SAPHanaTopology

Line 568 in fabfd37

hdbMap="hdbnsutil -sr_state"

    hdbMap="hdbnsutil -sr_state"
    if version "$hdbver" ">=" "1.00.111"; then
        hdbState="hdbnsutil -sr_stateConfiguration"
        hdbMap="hdbnsutil -sr_stateHostMapping"
    fi

    if version "$hdbver" ">=" "1.00.111"; then
        hdbANSWER=$(HANA_CALL --timeout "$HANA_CALL_TIMEOUT" --cmd "$hdbMap --sapcontrol=1" 2>/dev/null)
    fi

[fmherschel]

@PeterPitterling In SAPHana the version is also used to decide, if we have the new parameter-set for -sr_register or the new one:
in SAPHana it's line 1460. And yes that is also for a very old SAP HANA version (1.00.110) in this case.

SAPHanaSR/ra/SAPHana

Line 1460 in fabfd37

if version "$hdbver" ">=" "1.00.110"; then

SAPHanaTopology in

SAPHanaSR/ra/SAPHanaTopology

Line 595 in fabfd37

hdbANSWER=$(HANA_CALL --timeout "$HANA_CALL_TIMEOUT" --cmd "$hdbState --sapcontrol=1" 2>/dev/null)

the command which is content of $hdbState is called. For old SAP HANA dbs this is the old
command -sr_state. With higther versions this was forbidden to be called, if it is not guaranteed, that the SAP HANA nameserver is running at this time.

[PeterPitterling]

I'm referring to hdbMap only .. not hdbvers nor hdbState.

hdbMap is only assigned, but never used within SAPHana
hdbMap is only used for >=111 releases within SAPHanaTopology. For older releases hdbMap=sr_state is not called. The assignment is therefore not required for <111

[fmherschel]

Thanks, @PeterPitterling. But that does not help to get rid of the HDB version.

[PeterPitterling]

Thanks, @PeterPitterling. But that does not help to get rid of the HDB version.

true, but this issue is not talking about HDB version ?!

[fmherschel]

But yes we could remove Lines 1001+1004 in SAPHana and 568 in SAPHanaTopology (which surprises me, because AFAIR we also used mapping for those versions. Maybe it is a bug in lines 624ff. it seams we lost the code for the mapping for SAP HANA 1.00.111 and nobody reported this ;-) Also an argument to get rid of the HDB version.