Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3d line width on appropriate parameter change #13

Open
altavir opened this issue Jan 3, 2020 · 3 comments
Open

Update 3d line width on appropriate parameter change #13

altavir opened this issue Jan 3, 2020 · 3 comments
Labels
bug Something isn't working fixed in dev Fixed, but not released

Comments

@altavir
Copy link
Member

altavir commented Jan 3, 2020

No description provided.

@pklimai
Copy link
Member

pklimai commented Feb 22, 2020

It looks like the lines are always displayed as width 1 - "Due to limitations of the OpenGL Core Profile with the WebGL renderer on most platforms linewidth will always be 1 regardless of the set value." (https://threejs.org/docs/#api/en/materials/LineBasicMaterial.linewidth).

So shall we draw cylinders instead of lines?

@altavir
Copy link
Member Author

altavir commented Feb 22, 2020

There are several existing solutions like this one: https://github.com/spite/THREE.MeshLine/blob/master/README.md. The problem with cylinder is that unlike the line it will scale when moving camera, and it is not the behavior we want.

@altavir
Copy link
Member Author

altavir commented Aug 19, 2022

Implemented separate ThreeMeshLineFactory and ThreeSmartLineFactory. The later chooses which implementation to use depending on the line thickness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Fixed, but not released
Projects
None yet
Development

No branches or pull requests

2 participants