Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tool units consistent #66

Open
elsevers opened this issue Mar 16, 2019 · 1 comment
Open

Make tool units consistent #66

elsevers opened this issue Mar 16, 2019 · 1 comment
Labels
enhancement New feature or request.
Milestone
In-Progress

Comments

@elsevers
Copy link
Contributor

When MagNet implements the various MakerBase and Drawer2dBase interfaces, we need to make sure that coordinate unit types are kept consistent.

The default length unit can be kept track of using code added in PR #65, commit ID 49a88c7. The default length unit class can then be used to convert all incoming coordinates to this type by leveraging code in PR #53.
@elsevers elsevers added the enhancement New feature or request. label Mar 16, 2019
@elsevers elsevers added this to the Tasks for 2019-03-18 milestone Mar 16, 2019
@elsevers elsevers mentioned this issue Mar 16, 2019
Merged
@elsevers
Copy link
Contributor Author

Make this change for XFEMM as well. See PR #99.

@elsevers elsevers mentioned this issue May 20, 2019
Merged
@npetersen2 npetersen2 removed their assignment Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request.
Projects
None yet
Milestone
In-Progress
Development

No branches or pull requests
2 participants
@elsevers @npetersen2