Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi Any chance of updating to PyTorch 1.0 ? #18

Open
JulesVerny opened this issue Dec 24, 2018 · 2 comments
Open

Hi Any chance of updating to PyTorch 1.0 ? #18

JulesVerny opened this issue Dec 24, 2018 · 2 comments

Comments

@JulesVerny
Copy link

JulesVerny commented Dec 24, 2018

Hello
I am finding it very difficult to install against the previous PyTorch 0.4.0, as it is now released at 1.0. Is it possible to support PyTorch 1.0 and update the code and samples ? Do we expect it to be very different or any errors ?

Observation>:
When I download and run setup.py, it seems to do an install. However When I then attempt a python import ptan, I do have noetd I get an error
file/home/jules/anaconda3/lib/python3.6/site-packages/ptan-0.3-py3.6.egg/ptan/common/wrapper.py
ImportError:Cannot import name 'spaces' in line 6 of wrapper.py

It seems to be a problem in my environment seeing spaces within gym. Although with Anaconda I always have to set sys.path.append("/home/jules/gym") to make the gym package visible, and usable I still cannot import gym.spaces under a bash python prompt.
However if I edit in VSCode, do the imports and run the python code it appears I can import ptan and run some cartpole example without errors.
=> So may not an Issue

@Shmuma
Copy link
Owner

Shmuma commented Dec 24, 2018

Hi! It's in my todo list, but cannot make any time estimations, sorry

@JulesVerny
Copy link
Author

No Worries - I now seem to be proceeding through the book anyway
Merry Christmas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants