Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types after ol 7 update #95

Closed
bozhidarc opened this issue Sep 17, 2022 · 3 comments
Closed

Missing types after ol 7 update #95

bozhidarc opened this issue Sep 17, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@bozhidarc
Copy link

Hi I found the following missing types after the release of OL 7.
I think those can be fixed by replacing them with ReturnType<Geometry["getType"]> and ReturnType<Overlay["getPositioning"]

Error: node_modules/@types/ol-ext/overlay/Popup.d.ts:84:33 - error TS2304: Cannot find name 'OverlayPositioning'.

84     setPositioning(pos?: typeof OverlayPositioning | string): void;
                                   ~~~~~~~~~~~~~~~~~~


Error: node_modules/@types/ol-ext/overlay/Tooltip.d.ts:5:32 - error TS2307: Cannot find module 'ol/OverlayPositioning' or its corresponding type declarations.

5 import OverlayPositioning from 'ol/OverlayPositioning';
                                 ~~~~~~~~~~~~~~~~~~~~~~~
@Siedlerchr Siedlerchr added the bug Something isn't working label Sep 17, 2022
@Siedlerchr
Copy link
Owner

Thanks. OverlayPositioninig as been renamed to Positioninig.
I also found some issues in the examples
Viglino/ol-ext#855

@Siedlerchr
Copy link
Owner

WIP: #96
I currently still have troubles getting the examples up and running. If you have any idea

@Siedlerchr
Copy link
Owner

I just released a version 3.0.0 which is now compatible with ol.ext 4.0.1 and ol7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants