Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to init FileSystemAssetSigner if 'ASSET_STORE_SECRET' is empty #141

Open
Steven-Chan opened this issue May 19, 2017 · 0 comments
Open

Comments

@Steven-Chan
Copy link
Contributor

I am using the same set of environment variable for skygear-server and py-skygear. While I had no problem using file system as asset store on skygear-server with ASSET_STORE_SECRET is set to empty, FileSystemAssetSigner throws exception when init.

I think it is the relevant code (in py-skygear/skygear/asset/fs.py):

        secret = options.asset_store_secret
        if not secret:
            raise Exception('Missing signing secret for fs asset store')

While there is no such checking in NewFileStore of skygear-server/pkg/server/asset/fs.go (https://github.com/SkygearIO/skygear-server/blob/master/pkg/server/asset/fs.go).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant