Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Use 'shadow' border #10

Closed
Bekaboo opened this issue Mar 27, 2023 · 1 comment
Closed

[Feature request] Use 'shadow' border #10

Bekaboo opened this issue Mar 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Bekaboo
Copy link

Bekaboo commented Mar 27, 2023

Firstly, thank you for making this awesome plugin!

The plugin works pretty good with little configuration, and this is a only request of aesthetic concern. I notice that when I use 'shadow' as the border style, the floating window looks weird:

image

It seems that there are actually two floating windows side by side, resulting in the gap in the middle. Can we make it more coherent? Thanks in advance!

@SmiteshP SmiteshP added the enhancement New feature or request label Mar 27, 2023
@SmiteshP
Copy link
Owner

SmiteshP commented Apr 5, 2023

Hi @Bekaboo !
I tried working out this issue. Not able to figure out why the gap in middle appears. Also nui.nvim only allows setting border_chars, and only using that its not possible to have the "floating" effect in bottom_left and top_right corners. Will need some manual highlighting in those corners I guess. Maybe this could be resolved as part of this issue . Will remove mentions of shadow style in docs until then.

@SmiteshP SmiteshP closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants