Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please rectify schemachange dry run output #257

Open
Jeevan-Raju opened this issue Jun 19, 2024 · 1 comment
Open

Please rectify schemachange dry run output #257

Jeevan-Raju opened this issue Jun 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Jeevan-Raju
Copy link

Jeevan-Raju commented Jun 19, 2024

Describe the bug
The schemachange dry run is used as a check before the actual implementation run to display the order of execution of the change scripts.

To Reproduce
Steps to reproduce the behavior:
Run a schemachange command using '--dry-run' parameter at the end.

Expected behavior
We would expect the Snowflake account details to be printed, scripts that would execute and NOT statements like ' Applying change script A__grant_permissions.sql ' as seen in the attached screenshot.

Screenshots
dry_run_output

Schemachange:

  • Version: 3.6.1

Additional context
As seen I'm trying to run a dry run of a schemachange command using change scripts(version, repeatable, always).
It would be very helpful and informative if the output of dry run is cleaned up, and doesn't show statements like ' Applying script xyz ' as it isn't actually applying any change scripts at this point of the dry run and hence it is misleading and confusing.

Please let me know if you require additional details. Thank you.

@Jeevan-Raju Jeevan-Raju added the bug Something isn't working label Jun 19, 2024
@sfc-gh-tmathew
Copy link
Collaborator

@Jeevan-Raju The purpose of the dry run was to understand which scripts will be applied/skipped and the order in which the scripts will be executed when schemachange actually runs.

The output does say "Running in dry-run mode" which means the script is not applying the scripts.

What kind of check are you doing with dry-run before actual implementation? Can you give a few examples ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants