Update reader width live when updating in reader view #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
force-pushed
the
pr/chancez/live_update_width_reader_settings
branch
4 times, most recently
from
edc0b3d to
d3b9a0e
Compare
schroda
reviewed
Jan 27, 2024
|
not sure if that is fixable with the way the reader and reader settings are implemented, but it does feel kinda laggy (if you look at the slider compared to the mouse position) |
chancez
force-pushed
the
pr/chancez/live_update_width_reader_settings
branch
2 times, most recently
from
1df2eb8 to
70b879c
Compare
|
@schroda Okay I took another stab, added |
chancez
force-pushed
the
pr/chancez/live_update_width_reader_settings
branch
from
70b879c to
841d2b9
Compare
schroda
reviewed
Jan 29, 2024
schroda
reviewed
Jan 29, 2024
schroda
reviewed
Jan 29, 2024
chancez
force-pushed
the
pr/chancez/live_update_width_reader_settings
branch
from
841d2b9 to
1e1b287
Compare
|
Pushed after rebasing and fixing what I could so I can get a re-review, but need to test things again. |
chancez
force-pushed
the
pr/chancez/live_update_width_reader_settings
branch
from
1e1b287 to
6be1e0e
Compare
|
Ok should be good, I tested and it seems to be working as expected. |
schroda
reviewed
Mar 18, 2024
schroda
reviewed
Mar 18, 2024
schroda
reviewed
Mar 18, 2024
chancez
force-pushed
the
pr/chancez/live_update_width_reader_settings
branch
from
6be1e0e to
42305ff
Compare
Basically, instead of updating the width of the image after clicking `ok`, the width is adjusted live, which makes it easier to figure out the right value for the manga being viewed. While implementing this, I realized we can't update the backend every time we re-render when `liveUpdate` is true, so I've updated the logic for persisting settings to support skipping the API call to save the settings in the backend, and only perform the API it when the user clicks ok on the number setting. Signed-off-by: Chance Zibolski <[email protected]>
chancez
force-pushed
the
pr/chancez/live_update_width_reader_settings
branch
from
42305ff to
27b8e91
Compare
schroda
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, instead of updating the width of the image after clicking
ok, the width is adjusted live, which makes it easier to figure out the right value for the manga being viewed.Ideally we could revert the changes with the
cancelbutton, but to do that requires tracking the value prior to the updates. With how the reader is designed currently, everything is usingsettingsdirectly and so it's tricky to separate the settings being used to draw the component and the settings that are saved. So instead I've disabled the cancel button whenliveUpdateis true, since settings are updated immediately.While implementing this, I realized we can't update the backend every time we re-render when
liveUpdateis true, so I've updated the logic for persisting settings to support skipping the API call to save the settings in the backend, and only perform the API it when the user clicks ok on the number setting.