Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SBOL_INLINE and SBOL_REVERSE_COMPLEMENT to new URIs #312

Closed
tcmitchell opened this issue Sep 21, 2021 · 4 comments
Closed

Update SBOL_INLINE and SBOL_REVERSE_COMPLEMENT to new URIs #312

tcmitchell opened this issue Sep 21, 2021 · 4 comments
Assignees
Milestone

Comments

@tcmitchell
Copy link
Collaborator

See SynBioDex/SEPs#111

@tcmitchell tcmitchell added this to the beta milestone Sep 23, 2021
@tcmitchell tcmitchell self-assigned this Feb 1, 2022
@tcmitchell
Copy link
Collaborator Author

Support for SO_FORWARD and SO_REVERSE were added in PR #327. I think we should leave SBOL_INLINE and SBOL_REVERSE_COMPLEMENT as they are since they are allowed and programs may want to make explicit checks for the URLs they represent. This means that there is no work to do on this issue.

@jakebeal
Copy link
Contributor

jakebeal commented Feb 1, 2022

Given that there is a SHOULD relation, would it be appropriate to mark SBOL_INLINE and SBOL_REVERSE_COMPLEMENT as deprecated, or otherwise encourage people away from them?

@tcmitchell
Copy link
Collaborator Author

would it be appropriate to mark SBOL_INLINE and SBOL_REVERSE_COMPLEMENT as deprecated

We could, and I considered that. But it's not as easy as marking a function as deprecated. See https://www.scrygroup.com/tutorial/2019-06-27/module_level_deprecations/

That seemed heavyweight enough that I was reluctant to do it. We absolutely can though. Let me know your thoughts @jakebeal

@jakebeal
Copy link
Contributor

jakebeal commented Feb 1, 2022

That seems like not too bad a lift. I'd suggest going ahead with marking them as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants