Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weaver Header and Footer should not be lazy loaded. #448

Open
kaladay opened this issue Oct 19, 2021 · 0 comments
Open

Weaver Header and Footer should not be lazy loaded. #448

kaladay opened this issue Oct 19, 2021 · 0 comments

Comments

@kaladay
Copy link
Contributor

kaladay commented Oct 19, 2021 •
edited
Loading

In the event that the footer gets setup as fixed, such as in tamu-library-components, then this needs to not be lazy-loaded.

weaver-components/projects/wvr-elements/src/lib/core/wvr-core.module.ts

Line 49 in e8ee49c

{ component: WvrFooterComponent, selector: 'wvre-footer', lazy: true },

The header should likely not be lazy loaded as well:

weaver-components/projects/wvr-elements/src/lib/core/wvr-core.module.ts

Line 50 in e8ee49c

{ component: WvrHeaderComponent, selector: 'wvre-header', lazy: true },

@kaladay kaladay changed the title Weaver Footer should not be lazy loaded. Weaver Header and Footer should not be lazy loaded. Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaladay