Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::span fails to construct on top on a array<T, 1> #76

Open
parcollet opened this issue Jul 31, 2024 · 1 comment
Open

std::span fails to construct on top on a array<T, 1> #76

parcollet opened this issue Jul 31, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@parcollet
Copy link
Member

Description

std::span fails to construct from an array<T, 1>

Steps to Reproduce

   auto v= nda::vector<long>{1,2,3};
   auto s  std::span<long>{v.begin(), v.end()};

The issue is that the iterator of array<T, 1> should be a contiguous_iterator, not just a random_access_iterator

Expected behavior:

It should construct the span

Actual behavior:

Does not compile.

Versions

unstable (OS X).

@parcollet parcollet added the bug Something isn't working label Jul 31, 2024
@parcollet parcollet self-assigned this Jul 31, 2024
@parcollet
Copy link
Member Author

  • Working on a patch, but some discussions necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant