Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tolerance type #2

Open
rlanzafame opened this issue Dec 19, 2024 · 0 comments
Open

add tolerance type #2

rlanzafame opened this issue Dec 19, 2024 · 0 comments

Comments

@rlanzafame
Copy link
Member

rlanzafame commented Dec 19, 2024

Issue #3 describes the "all or each" approach, which should also be applied to this.

allow for different types of tolerance, specified in a new dict key: tolerance_type

I propose these types, defined here, but check the numpy isclose Notes and make sure you are consistent with that:

  • absolute as expected
  • relative as expected

Example:

exercise = {
    "type": "values",
    "tolerance": 0.01,
    "tolerance_type": "absolute",
    "variables": ['multiplication', 'addition'],
    "values": [13.889, 7.53]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant