Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.copilotignore extension wide, folder independent #175

Open
TerminalFi opened this issue Jul 3, 2024 · 2 comments
Open

.copilotignore extension wide, folder independent #175

TerminalFi opened this issue Jul 3, 2024 · 2 comments
Labels
enhancement New feature or request question Asking usage questions

Comments

@TerminalFi
Copy link
Owner

TerminalFi commented Jul 3, 2024

When working on the .copilotignore feature, one thing I kept going back to is why does this have to be a file in a folder. Why can't we support a plugin setting that is a blanket setting.

This is most useful when being present with files which are common across projects. But not necessarily containing a .copilotignore file.

I am thinking that we just implement a setting

.copilotignore which just mimics what a file might contain.

{
    "settings": {
        ".copilotignore": [
            ".env",
            ".envrc",
            "**/*/application.dev.yaml"
        ]
    }
}

I don't see much reason to not support this other than the consider added complexity or maintenance.

I don't see an issue with adding a feature that VS Code Copilot doesn't have, since they already have partial support of copilotignore files and most reports by people say it's only for enterprise

@TerminalFi TerminalFi added enhancement New feature or request question Asking usage questions labels Jul 4, 2024
@jfcherng
Copy link
Collaborator

jfcherng commented Jul 4, 2024

Can .copilotignore un-ignored file patterns? E.g., in .gitignore,

*
!foo

This will ignore everything excepts foo.


What are the final patterns if both settings and .copilotignore both exist?

@TerminalFi
Copy link
Owner Author

No, we aren't supporting the same logic as .gitignore. In fact, we don't even support comments today. Which we probably should.

I don't think we need to be super complex, I just believe this would give an easy way to just have global setting.

As for the final patterns, since I don't believe we need to support things identical to .gitignore, we could just use a set to get unique values then store them normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Asking usage questions
Projects
None yet
Development

No branches or pull requests

2 participants