Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race on Publish for Google pubsub #432

Closed
tsurunoyu opened this issue Apr 11, 2024 · 1 comment
Closed

Data race on Publish for Google pubsub #432

tsurunoyu opened this issue Apr 11, 2024 · 1 comment

Comments

@tsurunoyu
Copy link

Running code with -race that publishes from multiple goroutines at the same time:

WARNING: DATA RACE
Write at 0x00c002c291d8 by goroutine 1498:
  github.com/ThreeDotsLabs/watermill-googlecloud/pkg/googlecloud.(*Publisher).Publish()
      github.com/ThreeDotsLabs/[email protected]/pkg/googlecloud/publisher.go:149 +0xe4
[...]

Previous write at 0x00c002c291d8 by goroutine 1439:
  github.com/ThreeDotsLabs/watermill-googlecloud/pkg/googlecloud.(*Publisher).Publish()
      github.com/ThreeDotsLabs/[email protected]/pkg/googlecloud/publisher.go:149 +0xe4
[...]

Line 149 is:

t.EnableMessageOrdering = p.config.EnableMessageOrdering

which is a write to a shared Topic without synchronization.
@m110
Copy link
Member

m110 commented Aug 26, 2024

Fixed in ThreeDotsLabs/watermill-googlecloud#33

@m110 m110 closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m110 @tsurunoyu