Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken flake8 pipeline in localhost #299

Open
cocolato opened this issue Jan 3, 2025 · 2 comments · May be fixed by #300
Open

Broken flake8 pipeline in localhost #299

cocolato opened this issue Jan 3, 2025 · 2 comments · May be fixed by #300

Comments

@cocolato
Copy link
Collaborator

cocolato commented Jan 3, 2025 •
edited
Loading

Python version: 3.9.21
flake8 version: 7.1.1

Run command：

uv run flake8 thriftpy2

Output:

thriftpy2/contrib/aio/socket.py:157:81: E501 line too long (81 > 80 characters)
thriftpy2/hook.py:13:81: E501 line too long (81 > 80 characters)
thriftpy2/parser/__init__.py:61:81: E501 line too long (86 > 80 characters)
thriftpy2/parser/__init__.py:67:81: E501 line too long (84 > 80 characters)
thriftpy2/parser/__init__.py:133:81: E501 line too long (90 > 80 characters)
thriftpy2/parser/exc.py:24:81: E501 line too long (94 > 80 characters)
thriftpy2/parser/parser.py:114:81: E501 line too long (82 > 80 characters)
thriftpy2/protocol/apache_json.py:91:81: E501 line too long (85 > 80 characters)
thriftpy2/protocol/apache_json.py:141:81: E501 line too long (84 > 80 characters)
thriftpy2/protocol/apache_json.py:149:81: E501 line too long (84 > 80 characters)
thriftpy2/protocol/apache_json.py:152:81: E501 line too long (109 > 80 characters)
thriftpy2/protocol/apache_json.py:153:81: E501 line too long (97 > 80 characters)
thriftpy2/protocol/apache_json.py:164:81: E501 line too long (111 > 80 characters)
thriftpy2/protocol/apache_json.py:165:81: E501 line too long (85 > 80 characters)
thriftpy2/protocol/apache_json.py:166:81: E501 line too long (118 > 80 characters)
thriftpy2/protocol/apache_json.py:167:81: E501 line too long (91 > 80 characters)
thriftpy2/protocol/apache_json.py:168:81: E501 line too long (86 > 80 characters)
thriftpy2/protocol/apache_json.py:175:81: E501 line too long (86 > 80 characters)
thriftpy2/protocol/apache_json.py:177:81: E501 line too long (98 > 80 characters)
thriftpy2/protocol/apache_json.py:179:81: E501 line too long (115 > 80 characters)
thriftpy2/protocol/apache_json.py:180:81: E501 line too long (95 > 80 characters)
thriftpy2/protocol/apache_json.py:185:81: E501 line too long (82 > 80 characters)
thriftpy2/protocol/apache_json.py:187:81: E501 line too long (87 > 80 characters)
thriftpy2/protocol/apache_json.py:203:81: E501 line too long (113 > 80 characters)
thriftpy2/protocol/apache_json.py:207:81: E501 line too long (92 > 80 characters)
thriftpy2/protocol/apache_json.py:212:81: E501 line too long (96 > 80 characters)
thriftpy2/protocol/apache_json.py:216:81: E501 line too long (96 > 80 characters)
thriftpy2/protocol/apache_json.py:237:81: E501 line too long (104 > 80 characters)
thriftpy2/protocol/apache_json.py:263:81: E501 line too long (89 > 80 characters)
thriftpy2/protocol/apache_json.py:273:81: E501 line too long (83 > 80 characters)
thriftpy2/protocol/apache_json.py:277:45: E226 missing whitespace around arithmetic operator
thriftpy2/protocol/apache_json.py:281:81: E501 line too long (84 > 80 characters)
thriftpy2/protocol/apache_json.py:283:81: E501 line too long (101 > 80 characters)
thriftpy2/protocol/apache_json.py:288:81: E501 line too long (92 > 80 characters)
thriftpy2/protocol/apache_json.py:310:81: E501 line too long (84 > 80 characters)
thriftpy2/protocol/apache_json.py:311:81: E501 line too long (82 > 80 characters)
thriftpy2/protocol/apache_json.py:312:81: E501 line too long (82 > 80 characters)
thriftpy2/protocol/cybin/__init__.py:1:1: F403 'from .cybin import *' used; unable to detect undefined names
thriftpy2/protocol/cybin/__init__.py:1:1: F401 '.cybin.*' imported but unused
thriftpy2/transport/sasl/__init__.py:42:81: E501 line too long (84 > 80 characters)
thriftpy2/transport/sasl/__init__.py:70:81: E501 line too long (98 > 80 characters)
thriftpy2/transport/sasl/__init__.py:81:81: E501 line too long (94 > 80 characters)
thriftpy2/transport/sasl/__init__.py:87:81: E501 line too long (99 > 80 characters)
thriftpy2/transport/sasl/__init__.py:142:81: E501 line too long (83 > 80 characters)
thriftpy2/transport/sasl/__init__.py:168:81: E501 line too long (87 > 80 characters)
@cocolato cocolato changed the title Broken flake pipeline in localhost Broken flake8 pipeline in localhost Jan 3, 2025
@cocolato
Copy link
Collaborator Author

cocolato commented Jan 3, 2025

This issue can also be reproduced in the local tox test.

@cocolato cocolato linked a pull request Jan 3, 2025 that will close this issue
Open
@aisk
Copy link
Member

aisk commented Jan 6, 2025

Most errors are E501, which means the lines are too long. I think 80 characters is a bit too short nowadays because wide screens are popular.

As a result, I'd like to increase the maximum line length (for example, to 120, because in the logs above, the longest line is 118). This way, we don't need to modify existing code too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix flake8 error in local test cocolato/thriftpy2
2 participants
@aisk @cocolato