Nightly feedstock build failed

[github-actions]

Nightly feedstock build failure for tiledbsoma-feedstock at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=43&_a=summary

[jdblischak]

All the jobs failed with a similar error:

[ 86%] Building C object src/CMakeFiles/TILEDB_SOMA_OBJECTS.dir/utils/nanoarrow.c.o
cc1: error: command-line option '-fvisibility-inlines-hidden' is valid for C++/ObjC++ but not for C [-Werror]
cc1: all warnings being treated as errors
make[5]: *** [src/CMakeFiles/TILEDB_SOMA_OBJECTS.dir/build.make:342: src/CMakeFiles/TILEDB_SOMA_OBJECTS.dir/utils/nanoarrow.c.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [CMakeFiles/Makefile2:100: src/CMakeFiles/TILEDB_SOMA_OBJECTS.dir/all] Error 2
make[3]: *** [Makefile:136: all] Error 2
make[2]: *** [CMakeFiles/libtiledbsoma.dir/build.make:86: libtiledbsoma-prefix/src/libtiledbsoma-stamp/libtiledbsoma-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/libtiledbsoma.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

I assume this was caused by PR single-cell-data/TileDB-SOMA#2188 to update and refactor nanoarrow, which was merged yesterday.

[eddelbuettel]

Yes. We had to remove -Werror as a blunt tool. We 'removed the removal' hence the re-appearance of the error.

[jdblischak]

Potential fix in single-cell-data/TileDB-SOMA#2366

[eddelbuettel]

Turned into a sequences of fixes and I remain a little perplexed why we needed them. Following single-cell-data/TileDB-SOMA@39f73ef there is now more green in the CI (while it is still running).

[johnkerl]

See also for follow-up
single-cell-data/TileDB-SOMA#2362

[jdblischak]

Closing now that single-cell-data/TileDB-SOMA#2366 was merged