G2.134 Outstanding tasks to complete processing of messages to the user

[carolyncaron]

Branch

G2.134-finishProcessTests
g2.134-addExceptionsToProcessors

Groups

Group 2 - Data Importing, Group 5 | Automated Testing | Performance

Describe

This issue outlines development tasks needed to follow PR #127 after its merged. Note that separate PRs can be done to address each task:

• Finish creating new tests in TraitImporterProcessValidationTest to trigger every case from each processing method implemented in PR G4.114 Finalize processValidationMessages() to generate user-friendly messages #127 and render the output to compare with expectations. Each test will have its own data provider.

  • testProcessValidDataFileFailures()
  • testProcessValidDelimitedFileFailures()
  • testProcessEmptyCellFailures()
  • testProcessValueInListFailures()

• Add checks to each new processing method that:

  • Validation statuses are indeed set to 'fail' and that 'failedItems' contains content. Otherwise, throw an exception and update the tests from task 1) accordingly.
  • That the case message is one of the anticipated cases, otherwise throw an exception.

Design

The design for task 1) should follow the standard set by these test methods from PR #127:

• testProcessGenusExistsFailures()
• testProcessValidHeadersFailures()
• testProcessDuplicateTraitsFailures()

[laceysanderson]

Just thought I'd post the comment that I added in the PR before this one in case it helps with some of the other tests:

Note regarding testProcessDuplicateTraitsFailures logic:
The current logic is good and fine to stay as is. That said, I wanted to respond to the following comment:

// Pull out the table rows for this table case.
$selected_table_rows = $this->cssSelect("table.table-case-$table_case tbody tr td");
// Keep track of the index in $selected_table_rows. This is necessary
// since there's no way to distinguish different rows in a table.
// ie:
// Row 1: $selected_table_rows[0], ..[1], ..[2], ..[3]
// Row 2: $selected_table_rows[4], ..[5], ..[6], ..[7]
// etc...

There is actually a way. What you would do is use the cssSelect to select the row instead of the cell. Then within the loop you already have you can do the following:

$selected_rows = $this->cssSelect("table.table-case-$table_case tbody tr");
$current_row_index = 0;
foreach ($table as $expected_line_no => $validation_status) {
  $select_row_cells = (array) $selected_rows[$current_row_index]->td;
}

which gives you a simple array of the cells for each row.

[reynoldtan]

This is an outstanding issue.