Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G0.135 - Resolve Problems and Bring to Standard #135

Open
16 tasks
reynoldtan opened this issue Dec 24, 2024 · 0 comments · May be fixed by #136
Open
16 tasks

G0.135 - Resolve Problems and Bring to Standard #135

reynoldtan opened this issue Dec 24, 2024 · 0 comments · May be fixed by #136
Assignees
@reynoldtan
Labels
Group 0 - General Only for tasks that do not fit in another category.

Comments

@reynoldtan
Copy link
Contributor

reynoldtan commented Dec 24, 2024 •
edited
Loading

Branch

g0.135-resolveProblemsAndBringToStandard

Groups

Group 0 - General

Describe

Resolve code problems reported by PHP Sniffer & Beautifier and apply code standards already applied to code mentioned in this issue #121
G2.121 Bring up to standards code pertaining to the Traits Importer

Design

Inspect code located in the src and tests directory for the following:

Controller

  • TripalCultivatePhenotypesSettingsController.php

Service

  • TripalCultivatePhenotypesFileTemplateService.php
  • TripalCultivatePhenotypesGenusOntologyService.php
  • TripalCultivatePhenotypesGenusProjectService.php
  • TripalCultivatePhenotypesTermsService.php
  • TripalCultivatePhenotypesTraitsService.php

Tests:
/Functional

  • ConfigOntologyTermsTest.php
  • ConfigRRulesTest.php
  • ConfigWatermarkTest.php
  • InstallTest.php

/Kernel/Traits

  • ValidTraitTest.php

/Kernel

  • ServiceGenusOntologyTest.php
  • ServiceGenusProjectTest.php
  • ServiceTemplateGeneratorTest.php
  • ServiceTermTest.php

/Traits

  • PhenotypeImporterTestTrait.php
@reynoldtan reynoldtan changed the title G0.[issueNo] Resolve Problems and Bring to Standard G0.135 - Resolve Problems and Bring to Standard Dec 24, 2024
@reynoldtan reynoldtan self-assigned this Dec 24, 2024
@reynoldtan reynoldtan added the Group 0 - General Only for tasks that do not fit in another category. label Dec 24, 2024
@reynoldtan reynoldtan linked a pull request Dec 24, 2024 that will close this issue
Draft
16 tasks
@reynoldtan reynoldtan linked a pull request Jan 2, 2025 that will close this issue
g0.135 Resolve problems and bring code to standard #136
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reynoldtan reynoldtan

Labels
Group 0 - General Only for tasks that do not fit in another category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

g0.135 Resolve problems and bring code to standard TripalCultivate/TripalCultivate-Phenotypes
1 participant
@reynoldtan