From da01d2a1b0b86ae10bbbc69d6af04423a8967796 Mon Sep 17 00:00:00 2001 From: Mitali Singh Date: Thu, 11 Jan 2024 18:56:21 +0530 Subject: [PATCH] Resolved Review comments AB#107519 --- .../FunctionalTests/RoSWebhookScenarios.cs | 2 +- .../Service/RoSWebhookEndpoint.cs | 2 +- .../UKHO.ERPFacade.API.FunctionalTests.csproj | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/UKHO.ERPFacade.API.FunctionalTests/FunctionalTests/RoSWebhookScenarios.cs b/tests/UKHO.ERPFacade.API.FunctionalTests/FunctionalTests/RoSWebhookScenarios.cs index dde5b10c..603e3d83 100644 --- a/tests/UKHO.ERPFacade.API.FunctionalTests/FunctionalTests/RoSWebhookScenarios.cs +++ b/tests/UKHO.ERPFacade.API.FunctionalTests/FunctionalTests/RoSWebhookScenarios.cs @@ -75,7 +75,7 @@ public async Task WhenValidRoSEventInRecordOfSalePublishedEventPostReceivedWithI [Test, Order(2)] [TestCase("LTC03_InValidLTCwithNoCorrelationID.json", TestName = "WhenValidRoSMigrateNewLicencePublishedEventReceivedWithInvalidPayload_ThenWebhookReturns400BadRequestResponse")] [TestCase("LTC05_InValidLTCwithNoCorrelationID.json", TestName = "WhenValidRoSMigrateExistingLicencePublishedEventReceivedWithInvalidPayload_ThenWebhookReturns400BadRequestResponse")] - [TestCase("LTC09_InValidLTCwithNoCorrelationID.json", TestName = "WhenValidRoSConvertTrialToFullLicencePublishedEventReceivedWithInvalidPayload_ThenWebhookReturns400BadRequestResponse")] + [TestCase("LTC09_InvalidLTCwithNoCorrelationID.json", TestName = "WhenValidRoSConvertTrialToFullLicencePublishedEventReceivedWithInvalidPayload_ThenWebhookReturns400BadRequestResponse")] [TestCase("RoS11_InValidRoSwithNoCorrelationID.json", TestName = "WhenInValidRoSEventInRecordOfSalePublishedEventPostReceived_ThenWebhookReturns400BadRequestResponse")] public async Task WhenInValidRoSEventInRecordOfSalePublishedEventPostReceived_ThenWebhookReturns400BadRequestResponse(string payloadFileName) { diff --git a/tests/UKHO.ERPFacade.API.FunctionalTests/Service/RoSWebhookEndpoint.cs b/tests/UKHO.ERPFacade.API.FunctionalTests/Service/RoSWebhookEndpoint.cs index 52248035..fcc7b5a8 100644 --- a/tests/UKHO.ERPFacade.API.FunctionalTests/Service/RoSWebhookEndpoint.cs +++ b/tests/UKHO.ERPFacade.API.FunctionalTests/Service/RoSWebhookEndpoint.cs @@ -14,7 +14,7 @@ public class RoSWebhookEndpoint private readonly AzureBlobStorageHelper _azureBlobStorageHelper; private const string RoSWebhookRequestEndPoint = "/webhook/recordofsalepublishedeventreceived"; public static string GeneratedCorrelationId = string.Empty; - public static string RecordOfSalesContainerName = "recordofsaleblobs"; + public const string RecordOfSalesContainerName = "recordofsaleblobs"; public RoSWebhookEndpoint() { diff --git a/tests/UKHO.ERPFacade.API.FunctionalTests/UKHO.ERPFacade.API.FunctionalTests.csproj b/tests/UKHO.ERPFacade.API.FunctionalTests/UKHO.ERPFacade.API.FunctionalTests.csproj index f4d966a8..49070a41 100644 --- a/tests/UKHO.ERPFacade.API.FunctionalTests/UKHO.ERPFacade.API.FunctionalTests.csproj +++ b/tests/UKHO.ERPFacade.API.FunctionalTests/UKHO.ERPFacade.API.FunctionalTests.csproj @@ -188,7 +188,7 @@ Always - + Always