Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server Step 5.1] - ordering of the chats in the top page is done server-side? #42

Open
mdazy opened this issue Dec 3, 2019 · 0 comments

Comments

@mdazy
Copy link

mdazy commented Dec 3, 2019

Hi,

The server-side code is OK but the reference to the client-side ChatsList component feels a bit weird.

// The chat will appear at the top of the ChatsList component

It implies that the service is making assumptions on the client-side usage and implementation, whereas it should really be the client relying on documented service API.

While it might make sense for the service to present its data in a (documented) particular order, it should not have to do so in order to achieve a specific result client-side, expecting it to display the data in the same order.

I'd rather expect server-side documentation that the chats are provided in a specific order, and client-side comments explaining that no reordering is necessary because the service API is designed that way, or explicit reordering client-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant