New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting price configuration right #886

Open

t-m-cor opened this issue Dec 13, 2024 Discussed in #878 · 0 comments

Labels

bug

t-m-cor commented Dec 13, 2024 •

edited

Loading

Discussed in #878

It seems that price configurations entrys are skipped if end-date < start-date.

This is a problem, as the configuration does not include year as an input (and should not IMHO).

As an example a price-entry starting 1. oct, and ending 31. mar will not(never?) be added.

I see two solutions (maybe there is some even better ?):

issue a warning, if end-date < start-date, when saving (like the “there are to many decimal-digits” warning), stating that it should be split into two (before/after 31/12)

Or, a little smoother/logical:

add some logic, like “IF end-date < start-date THEN end-date += 1 year”, before comparing to current date/time

gskjold added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment