From 2e20854651ac9ee977d17c5c2f635108a14e4bbb Mon Sep 17 00:00:00 2001 From: Hiroshiba Date: Sun, 10 Mar 2024 01:05:20 +0900 Subject: [PATCH 1/3] =?UTF-8?q?[release-0.17]=20hotfix:=20=E3=83=97?= =?UTF-8?q?=E3=83=AD=E3=82=B8=E3=82=A7=E3=82=AF=E3=83=88=E3=83=95=E3=82=A1?= =?UTF-8?q?=E3=82=A4=E3=83=AB=E8=AA=AD=E3=81=BF=E8=BE=BC=E3=81=BF=E3=81=A8?= =?UTF-8?q?=E5=A3=B0=E9=87=8F=E3=83=BB=E9=9F=B3=E5=9F=9F=E3=83=91=E3=83=A9?= =?UTF-8?q?=E3=83=A1=E3=83=BC=E3=82=BF=E3=81=AE=E5=88=9D=E6=9C=9F=E5=8C=96?= =?UTF-8?q?=E3=83=90=E3=82=B0=E4=BF=AE=E6=AD=A3=20(#1927)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * ロジェクトファイル読み込みと声量・音域パラメータの初期化バグ修正 * ワークアラウンド追加 --- src/components/Sing/SingEditor.vue | 10 ++++++++-- src/components/Sing/ToolBar.vue | 25 ++++++++++++++++--------- src/store/project.ts | 3 +++ 3 files changed, 27 insertions(+), 11 deletions(-) diff --git a/src/components/Sing/SingEditor.vue b/src/components/Sing/SingEditor.vue index 27da8b6c09..a88a2c1ad7 100644 --- a/src/components/Sing/SingEditor.vue +++ b/src/components/Sing/SingEditor.vue @@ -89,6 +89,14 @@ onetimeWatch( notes: [], }, }); + + // CI上のe2eテストのNemoエンジンには歌手がいないためエラーになるのでワークアラウンド + // FIXME: 歌手をいると見せかけるmock APIを作り、ここのtry catchを削除する + try { + await store.dispatch("SET_SINGER", {}); + } catch (e) { + window.backend.logError(e); + } } await store.dispatch("SET_VOLUME", { volume: 0.6 }); @@ -101,8 +109,6 @@ onetimeWatch( }); isCompletedInitialStartup.value = true; - await store.dispatch("SET_SINGER", {}); - return "unwatch"; }, { diff --git a/src/components/Sing/ToolBar.vue b/src/components/Sing/ToolBar.vue index 4838290011..a8a8172d64 100644 --- a/src/components/Sing/ToolBar.vue +++ b/src/components/Sing/ToolBar.vue @@ -134,7 +134,6 @@