Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kickstarting development in our team #48

Open
amenk opened this issue May 24, 2017 · 6 comments
Open

Kickstarting development in our team #48

amenk opened this issue May 24, 2017 · 6 comments
Labels

Comments

@amenk
Copy link
Collaborator

amenk commented May 24, 2017

Hi,

we would like to assign one of our developers for improvement of the extension.

Can we start with that a fork? What should we know? I think it would be mostly frontend - I would compile a list of features (mostly those I reported).

I think you wanted to restructure the frontend? Should we first help with that?

@teh
Copy link
Member

teh commented May 25, 2017

Hi Alexander,

That's an amazing offer, thanks!

IMHO there'd be two super useful starting points:

  1. Add types viavia flow [1] or typescript. We don't have a comprehensive testing framework but good types could absorb a lot of that.
  2. Adding a module system to avoid all the global variables. This would also help substantially with getting the extension past the Firefox reviewers because we can pull out individual parts easier.

Those two points are somewhat related because type checkers need proper modules to function.

I have an aborted attempt for adding flow types and modules in the same branch [2]. I ran out of time.

[1]
http://flow.org/

[2]
https://github.com/WeAreWizards/passopolis-extensions/pull/49/files

@amenk
Copy link
Collaborator Author

amenk commented May 29, 2017

After the general fixing and making the code base ready for further development, our priorities would be:

  1. Upload signed Firefox Addon to Store #30
  2. Offline Capabilites #21

Can you maybe create a github project?

@amenk
Copy link
Collaborator Author

amenk commented Jul 2, 2017

How long did you work on that branch and how much work left do you see in it (roughly in hours) ?
What is the exact process to add a type? Could it be done as well by a beginning developer?

@teh
Copy link
Member

teh commented Jul 9, 2017

@amenk I spent maybe 3 days full time on that branch.

Can you maybe create a github project?

Not sure what you mean. Is it https://help.github.com/articles/about-project-boards/ ? Happy to set that up and make you contributors if that's what you have in mind.

@amenk
Copy link
Collaborator Author

amenk commented Jul 9, 2017

Yes I mean the project board.
We have around max. 30h our budget for the project, to make it useful for us...
Our developer estimated most of this for type script conversion, so there is nothing left for the important features. So I did not yet get the go-ahead...

I think the type script thing might be also something for a junior developer? Just have to find out how it works ... So s/he might be able to do that - with the main goal to bring the Firefox plugin forward, which is currently a show stopper....

@amenk
Copy link
Collaborator Author

amenk commented Jul 9, 2017

I think it would be nice if you make me us a contributor ... would set up a board / roadmap then and we can discuss about the priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants