From 27d0cb049e449b899279703807983dafcb1d3f69 Mon Sep 17 00:00:00 2001 From: Dierk Koenig Date: Sat, 30 Nov 2024 21:31:26 +0100 Subject: [PATCH] navigation: do not remove the page styleElement because of rendering issues when passivation and re-activation styling overlap in time --- docs/src/kolibri/navigation/projector/siteProjector.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/src/kolibri/navigation/projector/siteProjector.js b/docs/src/kolibri/navigation/projector/siteProjector.js index 6f09737a..4cece7db 100644 --- a/docs/src/kolibri/navigation/projector/siteProjector.js +++ b/docs/src/kolibri/navigation/projector/siteProjector.js @@ -51,10 +51,8 @@ const SiteProjector = siteController => { setTimeout( _time => { // give the passivation anim some time page.contentElement.classList.remove("passivate"); // just to be sure passiveContentElement.innerHTML = ""; // remove all children - page.styleElement.remove(); // proper cleanup, even though it should not be needed - // Note that while an overlapping page transition animation runs, the style elements from - // both pages are still in the head. So it is still best practice to user proper css nesting - // as in the examples to avoid conflicts. + // we do not remove the page styleElement because of issues when + // passivation and re-activation styling overlaps }, page.passivationMs); });