Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAPER BUG/ENHANCMENT] Commands are not properly hidden when the permission for that command is set to false #737

Open
phant0m2290 opened this issue Dec 20, 2024 · 5 comments
Labels
status: needs testing This needs video proof and testing

Comments

@phant0m2290
Copy link

When setting a permission to false for a command it should also hide the command from tabcomplete. Currently that does not happen.

@WiIIiam278
Copy link
Owner

could you clarify which command this is not working for?

@WiIIiam278 WiIIiam278 added the status: needs testing This needs video proof and testing label Dec 22, 2024
@phant0m2290
Copy link
Author

phant0m2290 commented Dec 22, 2024

all of them.
To reproduce:

  • Create a paper server with HuskHomes and Luckperms (or any other permission plugin)
  • Deny the use of any huskhomes command
  • Try to enter the command as a player
  • It should still show the command as a possible suggestion

When ran it does show a message saying that i dont have the correct perms but i can still see it

@WiIIiam278
Copy link
Owner

i'm doubtful because the commands should be registered to the command map with corresponding perms but worth checking

@phant0m2290
Copy link
Author

phant0m2290 commented Dec 26, 2024

Luckperms config

Screenshot 2024-12-26 185602

Example of the huskhomes command with permission set to false (same happens when its unset or set to true)

Screenshot 2024-12-26 185418

Example with the plugin command permission set to false

Screenshot 2024-12-26 185426

Example with the plugin command permission set to default (true)

Screenshot 2024-12-26 185437

@WiIIiam278
Copy link
Owner

Thanks for the diagnostics. Will look into this soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs testing This needs video proof and testing
Projects
None yet
Development

No branches or pull requests

2 participants