Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive UI and front page #39

Open
serra opened this issue May 16, 2020 · 8 comments
Open

Responsive UI and front page #39

serra opened this issue May 16, 2020 · 8 comments

Comments

@serra
Copy link
Member

serra commented May 16, 2020

With #41 it is better, but we still have responsiveness issues ont the front page.

The real problem is that we try to jam too much content on the front page.
This leads to scrolling issues and a less responsive frontpage.

Better would be:

  • use the default skeleton breakpoints as these match default screen sizes for common devices
  • strip down the top menu to 5 top level items max
  • reduce the content in the manifesto and about sections so that they better fit the page and trigger additional clicks on the website
  • fix the column selectors 4u 6u 12u in the sponsors section to better match the width
    But that is for some other time.
@serra
Copy link
Member Author

serra commented May 16, 2020

Course of action:

  1. confirm with peter that we're talking about the responsiveness of the main page here (and indentify how I can recognize the issue
  2. if so, use the history of the main page to verify in which version this behavior got introduced
  3. fix it

@serra
Copy link
Member Author

serra commented May 16, 2020

So what is happening is that the skeleton still has the old breakpoint in the javascript somewhere, but they do no longer correspond to the breakpoint in the css. Note that the skeleton still switches between modes:

image

It does so at the OLD breakpoints, modified in fcf7b9e:

image

@serra
Copy link
Member Author

serra commented May 16, 2020

☝️ that might explain the awkward scrolling behavior of the main pages as that is handled by javascript.

@serra
Copy link
Member Author

serra commented May 20, 2020

image

@serra
Copy link
Member Author

serra commented May 20, 2020

image

@serra
Copy link
Member Author

serra commented May 20, 2020

I suspect that this was the motivation behind the change in the style sheet. For things to keep working it is better to keep the skeleton boundaries. E.g.:
(in _landed.scss)

	@include skel-breakpoints((
		xlarge: '(max-width: 1680px)',   // original: 1680
		large: '(max-width: 1680px)',    // original: 1280
		medium: '(max-width: 1280px)',    // original:  980
		small: '(max-width: 980px)',     // original:  736
		xsmall: '(max-width: 480px)'     // original:  480
	));

@serra
Copy link
Member Author

serra commented May 20, 2020

But we still have to drop one (on or more) top-level item(s) from the main menu.

@serra
Copy link
Member Author

serra commented May 22, 2020

Some old notes:

Slack conversation leading to this issue:

image

History for _landed.scss
shows that the last relevant change to _landed.scss was on January 29th, where basically the larger layout settings were disable by setting them to extremely large values (13thousand pixels and up) in commit fcf7b9e.

That resembles the change Peter refers to and it is currently live.

Maybe there have been other changes too to other files too? Let's check that out.
mixins, vars and functions did not change:

image

main.css.scss did change, but none of the other css files:
image

On January 31st I made some changes to main.css.scss, could they have resulted in different behaviors? 9489f63 and 626ab9c

On Feb 4th I removed several scss files with commit b603acb. Could that be a problem?

Let's also check the history of the main page ... defintively things going on there too.

@serra serra changed the title Stylesheet issues wrt responsive UI Responsive UI and front page May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant