Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance existing Notification (toast message) #14

Open
uxkai opened this issue Jan 15, 2024 · 1 comment
Open

Enhance existing Notification (toast message) #14

uxkai opened this issue Jan 15, 2024 · 1 comment

Comments

@uxkai
Copy link

uxkai commented Jan 15, 2024

For the in-app review designs in Shopify, we've designed a more advanced toast message notification with action buttons. These buttons should be aligned completely to the right (following our UI patterns in Yoast SEO), below the close icon.

Additionally, for all our current notifications in the UI library, we want to include a 4px margin below the notification title. (based on Tailwind UI notifications)

Screenshot_2024-01-15_at_11_23_48
@igorschoester
Copy link
Member

The buttons on the bottom extending all the way to the edge makes it so we have to offer a place outside of the grid container.
The inverse of control is needed here to make it flexible enough for these needs. I'm thinking:

  • the Notification is then only the Transition
  • Notification.Grid, Notification.Grid.Shrink, Notification.Grid.Grow for the grid structure? Tricky one.
  • The current components:
    • Notification.ValidationIcon
    • Notification.Title
    • Notification.Description
    • Notication.DismissButton -- or whatever name is more fitting 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants