Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting and ending stops close to each other - wrong order #67

Open
mutipg opened this issue Feb 2, 2024 · 2 comments
Open

Starting and ending stops close to each other - wrong order #67

mutipg opened this issue Feb 2, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mutipg
Copy link

mutipg commented Feb 2, 2024

When the start and end stops are close to each other, Relatify does not arrange them in the correct order.

In the picture, each stop 'Dom Marynarza 03' and 'Dom Marynarza 05' have their own points with stop and platform roles and the bus route is arranged in the correct order. Despite this, the stop 'Dom Marynarza 05' was placed second instead of at the end of the list.

RELATION #: 2283346
image
image

@Zaczero Zaczero added the bug Something isn't working label Feb 2, 2024
@Zaczero
Copy link
Owner

Zaczero commented Feb 2, 2024

The cause of this bug is that the bus stop is matched to the nearest way. So, the starting way has 2 bus stops matched to it. I think a good fix for it would be to match to the nearest way where the bus stop is on the right-hand side, and then optionally fallback to matching any closest way. Thank you for reporting the issue!

@mutipg
Copy link
Author

mutipg commented Aug 21, 2024

I noticed a similar problem when editing this relation, where:

  • Mikołów Dworzec 1 is the starting stop,
  • Mikołów Dworzec 4 is an intermediate stop in the middle of the relation,
  • Mikołów Dworzec 6 is the final stop.

Relatify created the correct route for this bus relation, but unfortunately Mikołów Dworzec 4 was placed in the relation right after the Mikołów Dworzec 1 stop instead of in the middle of it.

https://relatify.monicz.dev/?relation=12187641&load=1

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants