Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sprout and sapling parameter downloads and preload config #7810

Closed
arya2 opened this issue Oct 24, 2023 · 2 comments · Fixed by #7844
Closed

Remove sprout and sapling parameter downloads and preload config #7810

arya2 opened this issue Oct 24, 2023 · 2 comments · Fixed by #7844
Assignees
@arya2
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement

Comments

@arya2
Copy link
Contributor

arya2 commented Oct 24, 2023

Motivation

This is cleanup for #7800.

See #7613 (comment).
@arya2 arya2 added C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup P-Medium ⚡ labels Oct 24, 2023
@arya2 arya2 self-assigned this Oct 24, 2023
@mpguerra mpguerra added this to Zebra Oct 24, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Oct 24, 2023
@teor2345
Copy link
Contributor

This cleanup specifically?

  • Remove the download task, ignore the debug_skip_parameter_preload config, remove any production code for downloads, and any test code that tests downloads or sets the config

@teor2345 teor2345 mentioned this issue Oct 24, 2023
Closed
@teor2345
Copy link
Contributor

Just to be clear, this is about everything except the zebrad download command and Dockerfiles, which is in #7811.

@arya2 arya2 mentioned this issue Oct 26, 2023
Merged
6 tasks
@mergify mergify bot closed this as completed in #7844 Oct 27, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arya2 arya2

Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement
Projects
Zebra
Archived in project
Milestone
No milestone
2 participants
@arya2 @teor2345