Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getblock RPC method #8446

Open
Tracked by #8435
mpguerra opened this issue Apr 24, 2024 · 3 comments · Fixed by #9008 or #9006
Open
Tracked by #8435

Update getblock RPC method #8446

mpguerra opened this issue Apr 24, 2024 · 3 comments · Fixed by #9008 or #9006
Assignees
@conradoplg

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Apr 24, 2024 •
edited
Loading

Motivation

This is needed for zcashd deprecation

https://zcash.github.io/rpc/getblock.html

Scope

  1. Identify remaining work to fully implement
@mpguerra mpguerra mentioned this issue Apr 24, 2024
Open
18 tasks
@github-project-automation github-project-automation bot moved this to New in Zebra Apr 24, 2024
@mpguerra mpguerra added this to the Block Explorer Support milestone Apr 24, 2024
@mpguerra mpguerra moved this from New to Product Backlog in Zebra Apr 24, 2024
@mpguerra mpguerra mentioned this issue Jun 20, 2024
Open
@dismad
Copy link
Contributor

dismad commented Sep 1, 2024

+1. I would like this method to match zcashd as much as possible. For example with block height when given a block hash.

@mpguerra mpguerra moved this from Product Backlog to Sprint Backlog in Zebra Sep 2, 2024
@mpguerra mpguerra assigned mpguerra and oxarbitrage and unassigned mpguerra and oxarbitrage Sep 23, 2024
@conradoplg
Copy link
Collaborator

Reported by pitmutt on Discord

Hello. I found that Zebra's response for RPC method getblock differs depending on whether you use a block height or a hash as the parameter. If you use a hash, the height field in the JSON response is missing.

Which seems the same as dismad's request

@mpguerra mpguerra removed this from the Block Explorer Support milestone Oct 18, 2024
@arya2 arya2 mentioned this issue Oct 25, 2024
Merged
6 tasks
This was linked to pull requests Nov 13, 2024
Suggestion for "change(rpc): Update getblock RPC to more closely match zcashd" #9008
Merged
change(rpc): Update getblock RPC to more closely match zcashd #9006
Merged
@mpguerra mpguerra added this to the Zebra can replace `zcashd` milestone Nov 20, 2024
@mpguerra mpguerra moved this from In progress to Review/QA in Zebra Dec 2, 2024
@mergify mergify bot closed this as completed in #9006 Dec 2, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Dec 2, 2024
@conradoplg
Copy link
Collaborator

Since this now has a bunch of sub-issues we shoudn't close this yet

@conradoplg conradoplg reopened this Dec 2, 2024
@conradoplg conradoplg mentioned this issue Dec 12, 2024
Merged
7 tasks
@mpguerra mpguerra moved this from Done to Sprint Backlog in Zebra Dec 19, 2024
@mpguerra mpguerra removed this from the Zebra Ready for zcashd Deprecation milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conradoplg conradoplg

Labels
None yet
Projects
Zebra
Status: Sprint Backlog
Milestone
No milestone
4 participants
@conradoplg @mpguerra @oxarbitrage @dismad