You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
Description
Three.js requires us to call .dispose() on certain objects once they are no longer used, and not doing so can cause memory leaks and performance issues. Since we're not calling .dispose()anywhere in the code at the moment, it sure wouldn't hurt resolving this issue.
Minimum Acceptance Criteria
Ensure the following three.js objects are cleaned up correctly (marble skins are intentionally cached and don't require cleanup when unused):
Description
Three.js requires us to call
.dispose()
on certain objects once they are no longer used, and not doing so can cause memory leaks and performance issues. Since we're not calling.dispose()
anywhere in the code at the moment, it sure wouldn't hurt resolving this issue.Minimum Acceptance Criteria
Ensure the following three.js objects are cleaned up correctly (marble skins are intentionally cached and don't require cleanup when unused):
Reference
https://threejs.org/docs/index.html#manual/en/introduction/How-to-dispose-of-objects
The text was updated successfully, but these errors were encountered: