Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Proper three.js object disposal #290

Open
3 tasks
Qaomen opened this issue Dec 16, 2020 · 0 comments
Open
3 tasks

Proper three.js object disposal #290

Qaomen opened this issue Dec 16, 2020 · 0 comments
Labels
bug something isn't working client affects the client editor affects the editor

Comments

@Qaomen
Copy link
Collaborator

Qaomen commented Dec 16, 2020

Description
Three.js requires us to call .dispose() on certain objects once they are no longer used, and not doing so can cause memory leaks and performance issues. Since we're not calling .dispose() anywhere in the code at the moment, it sure wouldn't hurt resolving this issue.

Minimum Acceptance Criteria
Ensure the following three.js objects are cleaned up correctly (marble skins are intentionally cached and don't require cleanup when unused):

  • Client: Level geometries, materials, and textures
  • Client: Marble name tags (textures and materials)
  • Editor: Level geometries, materials, and textures

Reference
https://threejs.org/docs/index.html#manual/en/introduction/How-to-dispose-of-objects

@Qaomen Qaomen added bug something isn't working editor affects the editor client affects the client labels Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug something isn't working client affects the client editor affects the editor
Projects
None yet
Development

No branches or pull requests

1 participant