Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS buggy with disabled fiat currency #2699

Open
myxmaster opened this issue Jan 2, 2025 · 1 comment
Open

POS buggy with disabled fiat currency #2699

myxmaster opened this issue Jan 2, 2025 · 1 comment
Labels
Bug Something isn't working Point of Sale

Comments

@myxmaster
Copy link
Contributor

Describe the bug

  1. Enable fiat currency and create a POS order. Then go to Settings, diable fiat currency and create another POS order -> POS order view still displays fiat values (probably cached rates?). => We need proper reloading of fiat settings for this case.
  2. After disabling fiat currency, kill the app and restart. Create another POS order -> It will display $N/A for Conversion rate which makes sense, but Total (Fiat) is $NaN (should be $N/A) and Total (Bitcoin) is NaN sats, but that sum should be calculated.

In general I think we should think about checking if fiat is enabled when POS is used ("Open" tab and creating an order, something else?) and if fiat is not enabled, display a modal with options to enable it or leave POS view.

Reproduce

...

ZEUS version

v0.9.5

Node interface

Multiple (specified in comments)

Network

Clearnet

Device

Pixel 7 Pro emulator

Device operating system

Android 14

Log output

No response

@myxmaster myxmaster added the Bug Something isn't working label Jan 2, 2025
@myxmaster
Copy link
Contributor Author

Maybe related to #2004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Point of Sale
Projects
None yet
Development

No branches or pull requests

2 participants