-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to deprecated v1 Android embedding #77
Comments
@reidbaker This is a good issue, I'm surprised this project hasn't been maintained for so long. Are you working on it? |
I am not. I filed bugs against the top 1000 "most popular" plugins that had v1 embedding references. This is more than 50 plugins down my list so I likely wont ever get to it. |
Here are the references. The good news is they are only in the example app which means customers (aka plugin users) will likely not be affected. |
I think I'll work on it in my free time. Should be a simple migration indeed |
flutter/engine#52022 has been merged. Users targeting Flutter master and beta/stable releases after (but not including) 3.27 will fail to compile if the plugin has references any v1 embedding classes. To aid in identifying these classes here is a search query you can run in github on your repo.
|
Remove references to deprecated v1 Android embedding
To ensure this plugin will work with users running the next stable version of Flutter remove references to the v1 embedding.
The v1 embedding was deprecated around 6 and a half years ago. In Flutter 3.22, the Flutter tool dropped support for building v1 apps entirely. Flutter plans to delete version one of it's Android embedding in the next stable release, per https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3 (in the "Removal of v1 Android embedding" section).
When that deletion happens, any apps using plugins that still have references to the removed classes will fail to build when updating to the next stable version (probably Flutter
3.26
).As a part of this deprecation, the Flutter Android team is doing community outreach by filing bugs and submitting some pull requests to update plugins to minimize the impact this removal has on the community.
Some example PRs:
android_alarm_manager_plus
fix(android_alarm_manager_plus): Remove references to v1 embedding fluttercommunity/plus_plugins#2864Consequences:
3.22
.If this change doesn't land, this plugin will instead be broken for all apps building on the next stable version of Flutter and beyond.
Is there a way to support both v1 and v2 embedding apps in the next stable version of Flutter?
No.
This is the PR where we are removing the deprecated engine classes: flutter/engine#52022
The text was updated successfully, but these errors were encountered: