Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look for "unresholved" paths #92

Open
abathur opened this issue Jan 11, 2023 · 0 comments
Open

look for "unresholved" paths #92

abathur opened this issue Jan 11, 2023 · 0 comments

Comments

@abathur
Copy link
Owner

abathur commented Jan 11, 2023

resholve's Nix API uses two separate builds:

  1. an inner build to let the shell project build its ~final source normally (in case for example its Makefile does any dynamic templating/generation/etc.)
  2. an outer build that just operates on and resholves the output of the first

This means that it's possible for something like the patchPhase to inadvertently introduce references to the unresholved output.

I'm not sure I want resholve itself to cope with these (since they're Nix-specific), but:

  • it might make sense for the Nix builder(s) to grep for them
  • it might make sense to be able to give resholve a list of forbidden strings, which the Nix API could do

Leaning towards grep?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant