Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%%MIDI gchordoff is not working #51

Open
tannineo opened this issue Oct 16, 2024 · 6 comments
Open

%%MIDI gchordoff is not working #51

tannineo opened this issue Oct 16, 2024 · 6 comments

Comments

@tannineo
Copy link

tannineo commented Oct 16, 2024

Here is the sample abc block, please notice %%MIDI gchordoff

X: 1
T: Cooley's
M: 4/4
L: 1/8
K: Emin
%%MIDI gchordoff
|:D2|"Em"EBBA B2 EB|\
    ~B2 AB dBAG|\
    "D"FDAD BDAD|\
    FDAD dAFD|
"Em"EBBA B2 EB|\
    B2 AB defg|\
    "D"afe^c dBAF|\
    "Em"DEFD E2:|
|:gf|"Em"eB B2 efge|\
    eB B2 gedB|\
    "D"A2 FA DAFA|\
    A2 FA defg|
"Em"eB B2 eBgB|\
    eB B2 defg|\
    "D"afe^c dBAF|\
    "Em"DEFD E2:|2|A4G2:|]

In this case I just want to disable the generated chords accompaniment, or use a different chord arrangement.
Please see abc2midi .

I tested both the published community plugin and the main branch build, they all have the same behavior of not processing %%MIDI gchord.

@tannineo tannineo changed the title %%MIDI gchord is not working %%MIDI gchordoff is not working Oct 16, 2024
@tannineo
Copy link
Author

Tested using "abcjs": "6.4.3", with %%MIDI gchord z can silent chords.

@alensiljak
Copy link
Collaborator

Hi! I'm not sure if you are saying that this example doesn't work with the Obsidian plugin but works with abcjs, or does it also not work with the latest abcjs.
Let me know if it is an issue with the plugin itself or do you think there's an issue with abcjs.
Obsidian plugins are so simple that the most that can be done is usually to update abcjs to the latest version. Any issues with abcjs should be addressed in the library's repository, so it can be addressed properly.

@tannineo
Copy link
Author

@alensiljak Thanks for the reply :D
I wonder if you can simply bump the version of abcjs, and then build and release on the community plugin store.
I see the latest update was 1 year ago.
Meanwhile the official plugin template and its package.json dependencies are also different.

@alensiljak
Copy link
Collaborator

Was there a new release of abcjs?

@paulrosen
Copy link

There is now another new version - so you can bump the version to 6.4.4.

@alensiljak
Copy link
Collaborator

Thanks, @paulrosen!
@tannineo, the latest version has just been published
https://github.com/abcjs-music/obsidian-plugin-abcjs/releases/tag/1.5.0
Let us know if this solves the issue, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants