Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat GM - Add Hearing Protection to missing headgear #10631

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Compat GM - Add Hearing Protection to missing headgear #10631

merged 4 commits into from
Jan 13, 2025
+51 −11

Conversation

Andx667
Copy link
Contributor

@Andx667 Andx667 commented Jan 6, 2025 •
edited
Loading

When merged this pull request will:

  • add HEARING_PROTECTION_PELTOR to some Helmets that were missing it
  • since gm_ge_headgear_beret_crew_blk is also the base class for some other items removed the entry for them
  • add GM to launch.toml

Closes #10629

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Andx667
Andx667 commented Jan 6, 2025
View reviewed changes
Copy link
Contributor Author

@Andx667 Andx667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if "Add" is correct or should be "Improve"

@Andx667 Andx667 mentioned this pull request Jan 6, 2025
Closed
@Andx667 Andx667 changed the title Compat GM: Add Hearing Proctection to missing helmets Compat GM - Add Hearing Proctection to missing helmets Jan 6, 2025
@Andx667 Andx667 changed the title Compat GM - Add Hearing Proctection to missing helmets GM Compat - Add Hearing Protection to missing helmets Jan 13, 2025
@LinkIsGrim LinkIsGrim added this to the 3.18.3 milestone Jan 13, 2025
@LinkIsGrim LinkIsGrim modified the milestones: 3.18.3, 3.18.2 Jan 13, 2025
@LinkIsGrim LinkIsGrim changed the title GM Compat - Add Hearing Protection to missing helmets Compat GM - Add Hearing Protection to missing helmets Jan 13, 2025
@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Jan 13, 2025
@LinkIsGrim LinkIsGrim changed the title Compat GM - Add Hearing Protection to missing helmets Compat GM - Add Hearing Protection to missing headgear Jan 13, 2025
@LinkIsGrim LinkIsGrim merged commit 31d459c into acemod:master Jan 13, 2025
3 checks passed
@Andx667 Andx667 deleted the add-more-gm-helmets-to-hearing-compat branch January 13, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.

Hearing - GM Compat - Missing Properties
2 participants
@Andx667 @LinkIsGrim