-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector2d: What is the recommended 1.x approach to accessing the removed helper methods #95
Comments
I deliberately pared down the API with the idea that it will be easier to add functionality to the API than remove functionality from it. I'm happy to consider methods on a case-by-case basis. I just don't want to add blanket backwards support. Let's look at the few you mentioned as a start.
And even if I decide not to add something back, I'm happy to show how I would implement it in terms of the new geometry primitives. |
angleBetween() or getBearingTo() and distTo() are the ones that are most critical to us. We have implemented them separately, but last year we used the versions from RR and we just wanted to know if those are coming back. It's interesting that the variant from apache commons Euclidean geometry Vector2D class also has similar functions built in, so I just curious why you're thinking of them as free function, should they come back. just wanting to learn. |
Oh nice.
My current inclination is to exclude them, though I'm open to being convinced otherwise.
I brought up the free function angle only because free functions can be added by a user without library support and used with the same syntax as if they were in the library to begin with. That isn't the case in Java with normal methods, and that fact IMO weighs more in favor of including additional utility methods in the library. |
Can't say we have a convincing argument, but we'd be happy for having them included in the library. It makes sense, for instance, when dynamically doing a just-in-time build of an action sequence that wants a tangent to a destination from a variable starting point. |
How should teams moving from .5 to 1.x handle the helper methods from Vector2d that the previous version had like angleBetween(), distTo(), projectOnto() and rotated()
Thanks
The text was updated successfully, but these errors were encountered: