Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kalman Filter backward pass is using measurements twice without weights #3994

Open
andiwand opened this issue Dec 18, 2024 · 2 comments
Open

Comments

@andiwand
Copy link
Contributor

After a discussion in acts-project/traccc#788 I believe that our backward pass smoothing implementation in the Kalman Filter is not correct. We simply start from the last state and run the same filter back in the other direction. This will result in using measurements twice without applying any weights and potentially biased covariances and parameters.

This might also affect the GSF implementation.

References

@paulgessinger
Copy link
Member

Which one is this? The jacobian unrolling or backwards propagation?

@andiwand
Copy link
Contributor Author

This only affects the backward propagation smoother for both KF and GSF. #3996 improves the situation by inflating the covariance in the backward pass. This will result in the best possible resolution at the reference surface and innermost measurement. However all the other track states will not have the best possible resolution. The question is if this is even necessary usually even though we definitely want to be able to produce them.

If forward, backward and smoothing steps would be decoupled the user could choose what they really want. This might also need some EDM changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants