Wrong truncation of indexFileName in StartServer.cpp

[Qup42]

Issue

When using a path that contains a /../ for the for the index the path is truncated in a wrong way.

Explanation

The responsible code is

completesearch/src/server/StartCompletionServer.cpp

Lines 429 to 430 in bfb452b

	string::size_type pos = indexFileName.find(".");
	baseName = pos != string::npos ? indexFileName.substr(0, pos) : indexFileName;

It tries to truncate the path of the index file s.t. the file extension is removed. This is done by searching for the first occurence of . with find. If there is one everything after this first found dot is removed. This method fails if the path itself contains a /../. AFAIK even /./ in paths result in valid paths.

Example

E.g. take the path /local/data/vvz/tf-support/../completesearch-new/data/vvz/vvz.hybrid. The correct baseName would be /local/data/vvz/tf-support/../completesearch-new/data/vvz/vvz. But the code determines /local/data/vvz/tf-support/ as baseName

Possible fix

This could be possibly be fixed by replacing string::find with string::find_last_of.