From 65bf312a2a1871bae82000406f471d68a9f8e7be Mon Sep 17 00:00:00 2001 From: Brad Simpson Date: Wed, 29 May 2024 14:46:50 -0600 Subject: [PATCH 1/3] Add default _target value in legacy schema --- properties.schema | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/properties.schema b/properties.schema index 6a77f86..2688638 100644 --- a/properties.schema +++ b/properties.schema @@ -101,7 +101,7 @@ "type": "string", "required": false, "enum": ["_blank", "_self", "_parent", "_top"], - "default": "", + "default": "_blank", "title": "Target attribute", "inputType": { "type": "Select", From 657246dfef0c4a5202e05c207bd11cf8fa478b3e Mon Sep 17 00:00:00 2001 From: Brad Simpson Date: Wed, 29 May 2024 14:47:06 -0600 Subject: [PATCH 2/3] Add default value for _target in example.json --- example.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example.json b/example.json index 844d0bf..40db3de 100644 --- a/example.json +++ b/example.json @@ -16,7 +16,7 @@ "small": "http://minionslovebananas.com/images/check-in-minion.jpg", "attribution": "Copyright © 2019", "_url": "", - "_target": "" + "_target": "_blank" }, "_isScrollable": false, "_defaultScrollPercent": 0, From a58ab90bdf4a4af81d8599502f25c0e09e927d95 Mon Sep 17 00:00:00 2001 From: Brad Simpson Date: Wed, 29 May 2024 14:47:37 -0600 Subject: [PATCH 3/3] Fix typo in PR template --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 750a692..f641119 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ * A sentence describing each fix ### Update -* A sentence describing each udpate +* A sentence describing each update ### New * A sentence describing each new feature