Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow numbered pins when using graphics as pins #337

Open
swashbuck opened this issue Dec 17, 2024 · 0 comments · May be fixed by #338
Open

Allow numbered pins when using graphics as pins #337

swashbuck opened this issue Dec 17, 2024 · 0 comments · May be fixed by #338
Assignees
@swashbuck
Labels
enhancement

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Dec 17, 2024 •
edited
Loading

Subject of the enhancement

It would be useful to allow showing numbered pins when using graphics as pins. Currently, _useNumberedPins is ignored if using _pin.src values.

adapt-contrib-hotgraphic/templates/hotgraphicLayoutPins.jsx

Lines 89 to 93 in 9fced3e

{(!_pin.src && _useNumberedPins && !_isVisited) &&
<span className="hotgraphic__pin-number" aria-hidden="true">
{index + 1}
</span>
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
1 participant
@swashbuck