Ensure post build clean occurs for non-mac&win platforms

[andrew-m-leonard]

Fixes adoptium/temurin-build#4095

The refactor of the internal signing pipeline code was not calling postBuildWSclean for non-Windows&Mac platforms

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

[andrew-m-leonard]

run tests

[sxa]

This is a side effect of having enableSigner mean two things:

1. Enable GPG signing
2. Enable the internal signing phase on applicable platforms (mac/windows).

Given the comment against this the if ( !enableSigner ) really wants to be if ( !enableInternalSigner ). This change will potentially clear out the workspace on Windows between the initial build and assemble phase which is not necessarily what we want. Would it make4 sense to switch the guard to something like if ( !enableSigner && (windows || mac) )

I thought I'd created an issue somewhere to try and create an explicit separate option for internal signing, which I think would be useful, but I can't find it so maybe I haven't created it yet :-)

[andrew-m-leonard]

@sxa Isn't that what this line does already? https://github.com/adoptium/ci-jenkins-pipelines/pull/1174/files#diff-b4bb07e2f448f9ad2986d69423ad0b704dcdc4d217d947f465e6ace3fde7a4b3R2049

[adamfarley]

LGTM

[sxa]

@sxa Isn't that what this line does already? https://github.com/adoptium/ci-jenkins-pipelines/pull/1174/files#diff-b4bb07e2f448f9ad2986d69423ad0b704dcdc4d217d947f465e6ace3fde7a4b3R2049

Yes ;-)

[eclipse-temurin-bot]

 PR TESTER RESULT 

✅ All pipelines passed! ✅