Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make verdi export inspect fast by default #4531

Closed
ltalirz opened this issue Oct 29, 2020 · 1 comment · Fixed by #5145
Closed

Make verdi export inspect fast by default #4531

ltalirz opened this issue Oct 29, 2020 · 1 comment · Fixed by #5145
Assignees

Comments

@ltalirz
Copy link
Member

ltalirz commented Oct 29, 2020

Is your feature request related to a problem? Please describe

At the moment verdi export inspect defaults to a statistics overview that requires loading the data.json as well.

$ verdi export inspect  export_pyrene_mofs_22Sep20.aiida
--------------  ------
Version aiida   1.3.1
Version format  0.9
Computers       3
Groups          62
Links           159872
Nodes           56832
Users           1
--------------  ------

While it is certainly useful to have the possibility of getting such statistics, it also makes the command unnecessarily slow for large export files.
Many use cases may already be served by just printing information available from the export metadata, such as export version, aiida version used to generate the archive, timestamp when it was created (note: the latter information is currently missing from the archive format).

Describe the solution you'd like

Move the statistics view to a --statistics flag.

Default to information that can be parsed from the metadata.json and print at the bottom of the screen the command to get the extra statistics, e.g.

$ verdi export inspect  export_pyrene_mofs_22Sep20.aiida
--------------  ------
Version aiida   1.3.1
Version format  0.9
--------------  ------

Run `verdi export inspect  export_pyrene_mofs_22Sep20.aiida` for statistics on the archive contents

P.S. This concerns the current archive format. I suggest we put this on hold for now and reevaluate this once the new archive format is in place - if the statistics are super fast, we may not need to implement this change.

@chrisjsewell
Copy link
Member

if the statistics are super fast, we may not need to implement this change.

That's the hope 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants